backend/frontend: gate send-to-self dropdown on firmware support #3625
Conversation
| alertUser(t('device.firmwareUpgradeRequired')); | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
in Pocket we use this
bitbox-wallet-app/frontends/web/src/routes/market/pocket.tsx
Lines 385 to 405 in 91c8611
There was a problem hiding this comment.
Nice. Will ask my agent to extract this into a resuable component later 😁
There was a problem hiding this comment.
@thisconnect done, PTAL.
There was a problem hiding this comment.
Tested with 9.18.0 and tried to find why it didn't show. But reading the code the FW upgrade dialog should only shows when handleSend is called. Could you change to it shows earlier?
I suggest either when the user clicks the dropdown or after choosing an option from the dropdown.
There was a problem hiding this comment.
Agree - I think it'd be nice to show it earlier, before the user presses the send btn
There was a problem hiding this comment.
Done now. I accidentally amended it into the previous commit, and it was too difficult to undo it, sorry!
This PR is now also building on top of #3653 (rebased)
PTAL
backend/handlers/handlers.go
Outdated
| handlers.log.WithField("requested", rootFingerprintHex).Warn("features requested for non-connected keystore") | ||
| return response{ | ||
| Success: false, | ||
| ErrorMessage: "keystore not connected", |
There was a problem hiding this comment.
[nit] maybe something clearer that shows the difference between this case and the one where connectedKeystore is nil?
benma
force-pushed
the
send-to-self-version-check
branch
2 times, most recently
from
8ca7859 to
0fdee13
Compare
benma
force-pushed
the
send-to-self-version-check
branch
from
0fdee13 to
55f4905
Compare
And move the check to when selecting the account already, not when clicking Review. `deviceIDs` is re-fetched so we don't have to pass it everywhere.
benma
force-pushed
the
send-to-self-version-check
branch
from
55f4905 to
cea342e
Compare
There was a problem hiding this comment.
tested (webdev, old fw, altcoins) LGTM
but I noticed an unrelated "bug" that is already on staging-send-to-self-dropdown
When I reject the signing on the device and the "Edit transaction" and "Review" again I get: `Failed to sign transaction: Invalid Psbt due to duplicate key
| <AppRouter | ||
| accounts={accounts} | ||
| activeAccounts={activeAccounts} | ||
| deviceIDs={deviceIDs} |
benma
merged commit f0dce1b
into
BitBoxSwiss:staging-send-to-self-dropdown
4 participants
No description provided.